fix: throw descriptive error when callbacks used with react #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1450/features
github-actions
bot
temporarily deployed
to
staging/pull/1450/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1450/typedoc
ttypic
approved these changes
Sep 25, 2023
owenpearson
force-pushed
the
react-callbacks-error-message
branch
from
2200b4e to
c2dcf50
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1450/features
github-actions
bot
temporarily deployed
to
staging/pull/1450/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1450/bundle-report
owenpearson
force-pushed
the
react-callbacks-error-message
branch
from
c2dcf50 to
9181064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the react lib would work with a non-Promise client but it would subtly break some of the hooks. This change makes it so that if someone accidentally forgets to use a Promise client they will immediately be shown a helpful error msg.